Merge ~mthaddon/juju-lint/+git/juju-lint:dict_keys into juju-lint:master

[Tom Haddon]

dict.keys() doesn't return an indexable object in python3 - convert to list lp#1783732

dict.keys() doesn't return an indexable object in python3 - convert to list lp#1783732

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Stuart Bishop (stub)]

Yup

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Change successfully merged at revision 9add4fc663838e463de90b95fdbe931cdfb49f36

diff --git a/jujulint.py b/jujulint.py
index 10b889d..05d68b0 100755
--- a/jujulint.py
+++ b/jujulint.py
@@ -203,10 +203,10 @@ def check_subs(model, lint_rules):
                 for app in model.apps_on_machines[machine]:
                     model.missing_subs[required_sub].add(app)
 
-    for sub in model.missing_subs.keys()[:]:
+    for sub in list(model.missing_subs.keys()):
         if not model.missing_subs[sub]:
             del model.missing_subs[sub]
-    for sub in model.extraneous_subs.keys()[:]:
+    for sub in list(model.extraneous_subs.keys()):
         if not model.extraneous_subs[sub]:
             del model.extraneous_subs[sub]