Code review comment for lp:~mthaddon/charms/trusty/swift-storage/workers-cpu-scaling

Hi Tom

Thanks for the MP - looks like a good feature to have.

Right now this branch introduces a test failure:

======================================================================
FAIL: test_swift_storage_server_context (unit_tests.test_swift_storage_context.SwiftStorageContextTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/jamespage/src/charms/review/swift-storage/unit_tests/test_swift_storage_context.py", line 71, in test_swift_storage_server_context
    self.assertEquals(ex, result)
AssertionError: {'container_server_port': '502', 'local_ip': '10.0.0.5', 'account_server_port': [truncated]... != {'local_ip': '10.0.0.5', 'workers': 4, 'object_server_threads_per_disk': 4, 'con [truncated]...
  {'account_server_port': '500',
   'container_server_port': '502',
   'local_ip': '10.0.0.5',
- 'object_server_port': '501'}
? ^

+ 'object_server_port': '501',
? ^

+ 'object_server_threads_per_disk': 4,
+ 'workers': 4}

Please could you fix up - you can run units tests by using 'make test'. You will need to patch out psutils.NUM_CPU's as well in order to make the test deterministic.

Cheers

James