Merge ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:ops-lib-pgsql into charm-k8s-mattermost:master

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: 15ce6c4f0c487d1c04ae73a1f5647f8b701454b2
Merged at revision: 56ee71941b9eb6a3ea30b3dc6f9293ae88ff50c9
Proposed branch: ~mthaddon/charm-k8s-mattermost/+git/charm-k8s-mattermost:ops-lib-pgsql
Merge into: charm-k8s-mattermost:master
Diff against target: 71 lines (+6/-4)
4 files modified
dev/null (+0/-1)
requirements.txt (+1/-0)
src/charm.py (+4/-2)
tox.ini (+1/-1)
Reviewer Review Type Date Requested Status
Stuart Bishop (community) Approve
Mattermost Charmers Pending
Review via email: mp+391507@code.launchpad.net

Commit message

Switch to using ops-lib-pgsql rather than submodules for PostgreSQL relation

Description of the change

Switch to using ops-lib-pgsql rather than submodules for PostgreSQL relation

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Stuart Bishop (stub) wrote :

This all looks correct.

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 56ee71941b9eb6a3ea30b3dc6f9293ae88ff50c9

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/.gitmodules b/.gitmodules
0deleted file mode 1006440deleted file mode 100644
index 5b9992b..0000000
--- a/.gitmodules
+++ /dev/null
@@ -1,3 +0,0 @@
1[submodule "mod/interface-pgsql"]
2 path = mod/interface-pgsql
3 url = lp:~stub/interface-pgsql/+git/operator
diff --git a/lib/interface/pgsql b/lib/interface/pgsql
4deleted file mode 1200000deleted file mode 120000
index fac7ffe..0000000
--- a/lib/interface/pgsql
+++ /dev/null
@@ -1 +0,0 @@
1../../mod/interface-pgsql/pgsql
2\ No newline at end of file0\ No newline at end of file
diff --git a/mod/interface-pgsql b/mod/interface-pgsql
3deleted file mode 1600001deleted file mode 160000
index 6f38023..0000000
--- a/mod/interface-pgsql
+++ /dev/null
@@ -1 +0,0 @@
1Subproject commit 6f38023049b15d5dcbe595880cfe3fdf51def83f
diff --git a/requirements.txt b/requirements.txt
index 2d81d3b..fd6adcd 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1 +1,2 @@
1ops1ops
2ops-lib-pgsql
diff --git a/src/charm.py b/src/charm.py
index 34f8922..2dc7a30 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -9,6 +9,7 @@ from ipaddress import ip_network
9from urllib.parse import urlparse9from urllib.parse import urlparse
10from zlib import crc3210from zlib import crc32
1111
12import ops.lib
12from ops.charm import (13from ops.charm import (
13 CharmBase,14 CharmBase,
14 CharmEvents,15 CharmEvents,
@@ -26,12 +27,13 @@ from ops.model import (
26 WaitingStatus,27 WaitingStatus,
27)28)
2829
29from interface import pgsql
30
31from utils import extend_list_merging_dicts_matched_by_key30from utils import extend_list_merging_dicts_matched_by_key
3231
33import logging32import logging
3433
34
35pgsql = ops.lib.use("pgsql", 1, "postgresql-charmers@lists.launchpad.net")
36
35logger = logging.getLogger()37logger = logging.getLogger()
3638
3739
diff --git a/tox.ini b/tox.ini
index 48bf1ab..066c5a8 100644
--- a/tox.ini
+++ b/tox.ini
@@ -24,7 +24,7 @@ passenv =
24 JUJU_REPOSITORY24 JUJU_REPOSITORY
25 PATH25 PATH
26commands =26commands =
27 pytest -v --ignore mod --ignore {toxinidir}/tests/unit {posargs}27 pytest -v --ignore {toxinidir}/tests/unit {posargs}
28deps = -r{toxinidir}/tests/functional/requirements.txt28deps = -r{toxinidir}/tests/functional/requirements.txt
29 -r{toxinidir}/requirements.txt29 -r{toxinidir}/requirements.txt
3030

Subscribers

People subscribed via source and target branches