Merge ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:deploy-from-charmhub into charm-k8s-ingress:master

Proposed by Tom Haddon
Status: Merged
Approved by: Jon Seager
Approved revision: 27a1de98385885dec2c91c1727ffdb97df3f37ec
Merged at revision: 482c095489fef0e4c3852cc0967e9f4595339117
Proposed branch: ~mthaddon/charm-k8s-ingress/+git/charm-k8s-ingress:deploy-from-charmhub
Merge into: charm-k8s-ingress:master
Diff against target: 58 lines (+6/-14)
2 files modified
README.md (+4/-12)
lib/charms/nginx_ingress_integrator/v0/ingress.py (+2/-2)
Reviewer Review Type Date Requested Status
ingress-charmers Pending
Review via email: mp+401555@code.launchpad.net

Commit message

We can now deploy from charmhub direct

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Merge proposal is approved, but source revision has changed, setting status to needs review.

Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 482c095489fef0e4c3852cc0967e9f4595339117

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/README.md b/README.md
index 9f2052b..d156990 100644
--- a/README.md
+++ b/README.md
@@ -10,20 +10,12 @@ size, etc.).
1010
11## Usage11## Usage
1212
13This charm needs to be built locally as charmhub.io can't yet host charms with
14"bases" in `metadata.yaml`. Once that's been added, deployment instructions
15will be updated, but for now, see the "Running the charm locally" section
16below.
17
18## Running the charm locally
19
20To build the charm, run `charmcraft build`.
21
22You'll need version to be using Juju [version 2.9-rc11](https://discourse.charmhub.io/t/juju-2-9-rc11-release-notes/4501) or later.13You'll need version to be using Juju [version 2.9-rc11](https://discourse.charmhub.io/t/juju-2-9-rc11-release-notes/4501) or later.
2314
24As an example, you could deploy this charm as follows:15As an example, you could deploy this charm as follows (we're using the name
16"ingress" in this model for brevity):
25```17```
26juju deploy ./nginx-ingress-integrator.charm ingress --resource placeholder-image=google/pause18juju deploy nginx-ingress-integrator ingress
27```19```
28To create an ingress for your service, you'd then add a relation to a charm20To create an ingress for your service, you'd then add a relation to a charm
29that supports the `ingress` relation. As an example:21that supports the `ingress` relation. As an example:
@@ -67,7 +59,7 @@ can still override the configuration of the ingress using Juju config. Using
67the above example, where your charm sets the `service-port` as "80" in the59the above example, where your charm sets the `service-port` as "80" in the
68relation, you could override this by doing the following:60relation, you could override this by doing the following:
69```61```
70juju deploy ./nginx-ingress-integrator.charm ingress --resource placeholder-image='google/pause' --config kube-config="$(microk8s config)"62juju deploy nginx-ingress-integrator ingress
71juju deploy ./gunicorn.charm --resource gunicorn-image='gunicorncharmers/gunicorn-app:edge'63juju deploy ./gunicorn.charm --resource gunicorn-image='gunicorncharmers/gunicorn-app:edge'
72juju relate ingress gunicorn64juju relate ingress gunicorn
73juju config ingress service-port=808065juju config ingress service-port=8080
diff --git a/lib/charms/nginx_ingress_integrator/v0/ingress.py b/lib/charms/nginx_ingress_integrator/v0/ingress.py
index a935d5a..066b257 100644
--- a/lib/charms/nginx_ingress_integrator/v0/ingress.py
+++ b/lib/charms/nginx_ingress_integrator/v0/ingress.py
@@ -19,7 +19,7 @@ Import `IngressRequires` in your charm, with two required options:
19 - session-cookie-max-age19 - session-cookie-max-age
20 - tls-secret-name20 - tls-secret-name
2121
22See `config.yaml` for descriptions of each, along with the required type.22See [the config section](https://charmhub.io/nginx-ingress-integrator/configure) for descriptions of each, along with the required type.
2323
24As an example, add the following to `src/charm.py`:24As an example, add the following to `src/charm.py`:
25```25```
@@ -55,7 +55,7 @@ LIBAPI = 0
5555
56# Increment this PATCH version before using `charmcraft publish-lib` or reset56# Increment this PATCH version before using `charmcraft publish-lib` or reset
57# to 0 if you are raising the major API version57# to 0 if you are raising the major API version
58LIBPATCH = 358LIBPATCH = 4
5959
60logger = logging.getLogger(__name__)60logger = logging.getLogger(__name__)
6161

Subscribers

People subscribed via source and target branches

to all changes: