Merge ~mthaddon/charm-k8s-bind/+git/charm-k8s-bind:rename-charm into charm-k8s-bind:master

Proposed by Tom Haddon
Status: Merged
Approved by: Tom Haddon
Approved revision: a2bf1f0fd18bb56a3b805017cac748faa72e52de
Merged at revision: 062a222b3144d59d6ad75548457de0ad1d1c16a4
Proposed branch: ~mthaddon/charm-k8s-bind/+git/charm-k8s-bind:rename-charm
Merge into: charm-k8s-bind:master
Diff against target: 125 lines (+14/-12)
5 files modified
.jujuignore (+1/-0)
Makefile (+2/-2)
README.md (+4/-4)
metadata.yaml (+2/-1)
tests/unit/test_charm.py (+5/-5)
Reviewer Review Type Date Requested Status
Barry Price Approve
Canonical IS Reviewers Pending
Review via email: mp+402883@code.launchpad.net

Commit message

Rename charm for consistency with others

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Barry Price (barryprice) wrote :

LGTM +1

review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 062a222b3144d59d6ad75548457de0ad1d1c16a4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/.jujuignore b/.jujuignore
index e8eb682..128851d 100644
--- a/.jujuignore
+++ b/.jujuignore
@@ -1,4 +1,5 @@
1*~1*~
2*.charm
2.coverage3.coverage
3.gitignore4.gitignore
4__pycache__5__pycache__
diff --git a/Makefile b/Makefile
index 6e99731..35b100d 100644
--- a/Makefile
+++ b/Makefile
@@ -12,7 +12,7 @@ lint: blacken
1212
13# We actually use the build directory created by charmcraft,13# We actually use the build directory created by charmcraft,
14# but the .charm file makes a much more convenient sentinel.14# but the .charm file makes a much more convenient sentinel.
15unittest: bind.charm15unittest: bind-k8s.charm
16 @tox -e unit16 @tox -e unit
1717
18test: lint unittest18test: lint unittest
@@ -21,7 +21,7 @@ clean:
21 @echo "Cleaning files"21 @echo "Cleaning files"
22 @git clean -fXd22 @git clean -fXd
2323
24bind.charm: src/*.py requirements.txt24bind-k8s.charm: src/*.py requirements.txt
25 charmcraft build25 charmcraft build
2626
27image-deps:27image-deps:
diff --git a/README.md b/README.md
index d53b3a5..3e31d97 100644
--- a/README.md
+++ b/README.md
@@ -16,7 +16,7 @@ details on using Juju with MicroK8s for easy local testing [see here](https://ju
1616
17To deploy this charm in a juju k8s model:17To deploy this charm in a juju k8s model:
18```18```
19juju deploy cs:~bind-charmers/bind19juju deploy bind-k8s
20```20```
21The charm will deploy bind with its stock Ubuntu package configuration, which21The charm will deploy bind with its stock Ubuntu package configuration, which
22will forward all queries to root name servers.22will forward all queries to root name servers.
@@ -30,7 +30,7 @@ which to populate the `/etc/bind/` directory within the pod(s).
30Since bind won't allow recursion from external clients by default, to allow30Since bind won't allow recursion from external clients by default, to allow
31easy testing, you can use [a repo with a copy of the stock config, modified to allow recursion from all RFC1918 networks](https://code.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed):31easy testing, you can use [a repo with a copy of the stock config, modified to allow recursion from all RFC1918 networks](https://code.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed):
32```32```
33juju config bind custom_config_repo=https://git.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed33juju config bind-k8s custom_config_repo=https://git.launchpad.net/~barryprice/junk/+git/etc-bind-stock-config-with-all-rfc1918-nets-allowed
34```34```
35Once the application is ready, you should be able to query the App's IP address35Once the application is ready, you should be able to query the App's IP address
36(not the Unit addresses) directly from your local machine:36(not the Unit addresses) directly from your local machine:
@@ -44,8 +44,8 @@ bind-test myk8s-localhost myk8s/localhost 2.8.6 unsupported 16:44:30+07:0
44App Version Status Scale Charm Store Rev OS Address Notes44App Version Status Scale Charm Store Rev OS Address Notes
45bind bind:edge active 1 bind jujucharms 2 kubernetes 10.152.183.24645bind bind:edge active 1 bind jujucharms 2 kubernetes 10.152.183.246
4646
47Unit Workload Agent Address Ports Message47Unit Workload Agent Address Ports Message
48bind/0* active idle 10.1.25.35 53/TCP,53/UDP Pod configured48bind-k8s/0* active idle 10.1.25.35 53/TCP,53/UDP Pod configured
4949
50$ dig +short example.com @10.152.183.24650$ dig +short example.com @10.152.183.246
5193.184.216.345193.184.216.34
diff --git a/metadata.yaml b/metadata.yaml
index 7b1d7b2..6c09e29 100644
--- a/metadata.yaml
+++ b/metadata.yaml
@@ -1,4 +1,5 @@
1name: bind1name: bind-k8s
2display-name: Bind
2summary: The original, complete open source DNS implementation.3summary: The original, complete open source DNS implementation.
3docs: https://discourse.charmhub.io/t/bind-documentation-overview/39734docs: https://discourse.charmhub.io/t/bind-documentation-overview/3973
4description: |5description: |
diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
index 85fe103..3938f12 100644
--- a/tests/unit/test_charm.py
+++ b/tests/unit/test_charm.py
@@ -117,7 +117,7 @@ class TestBindK8s(unittest.TestCase):
117 'version': 2,117 'version': 2,
118 'containers': [118 'containers': [
119 {119 {
120 'name': 'bind',120 'name': 'bind-k8s',
121 'imageDetails': {'imagePath': 'example.com/bind:v1'},121 'imageDetails': {'imagePath': 'example.com/bind:v1'},
122 'ports': [122 'ports': [
123 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},123 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},
@@ -137,7 +137,7 @@ class TestBindK8s(unittest.TestCase):
137 'version': 2,137 'version': 2,
138 'containers': [138 'containers': [
139 {139 {
140 'name': 'bind',140 'name': 'bind-k8s',
141 'imageDetails': {141 'imageDetails': {
142 'imagePath': 'secure.example.com/bind:v1',142 'imagePath': 'secure.example.com/bind:v1',
143 'username': 'test-user',143 'username': 'test-user',
@@ -161,7 +161,7 @@ class TestBindK8s(unittest.TestCase):
161 'version': 2,161 'version': 2,
162 'containers': [162 'containers': [
163 {163 {
164 'name': 'bind',164 'name': 'bind-k8s',
165 'imageDetails': {'imagePath': 'example.com/bind:v1'},165 'imageDetails': {'imagePath': 'example.com/bind:v1'},
166 'ports': [166 'ports': [
167 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},167 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},
@@ -181,7 +181,7 @@ class TestBindK8s(unittest.TestCase):
181 'version': 2,181 'version': 2,
182 'containers': [182 'containers': [
183 {183 {
184 'name': 'bind',184 'name': 'bind-k8s',
185 'imageDetails': {'imagePath': 'example.com/bind:v1'},185 'imageDetails': {'imagePath': 'example.com/bind:v1'},
186 'ports': [186 'ports': [
187 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},187 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},
@@ -201,7 +201,7 @@ class TestBindK8s(unittest.TestCase):
201 'version': 2,201 'version': 2,
202 'containers': [202 'containers': [
203 {203 {
204 'name': 'bind',204 'name': 'bind-k8s',
205 'imageDetails': {'imagePath': 'example.com/bind:v1'},205 'imageDetails': {'imagePath': 'example.com/bind:v1'},
206 'ports': [206 'ports': [
207 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},207 {'containerPort': 53, 'name': 'domain-tcp', 'protocol': 'TCP'},

Subscribers

People subscribed via source and target branches

to all changes: