Code review comment for lp:~mterry/webbrowser-app/switch-tab-keybinding

Revision history for this message
Olivier Tilloy (osomon) wrote :

The following autopilot test is broken:

    webbrowser_app.tests.test_tabs.TestTabsManagement.test_selecting_tab_focuses_webview

I can reliably observe the failure on desktop by running the test in narrow mode: modify the width of the window to be 50GU instead of 100GU in src/app/BrowserWindow.qml, and then run the test locally:

    cd tests/autopilot
    autopilot3 run webbrowser_app.tests.test_tabs.TestTabsManagement.test_selecting_tab_focuses_webview

I’m guessing the change to switchToTab() is what introduced the regression: when selecting a tab from the tabs view (in narrow mode), the recent view is still visible, so we don’t want to focus back the recent view. My bad for suggesting to factor this out, can you please revert that change?

review: Needs Fixing

« Back to merge proposal