Code review comment for lp:~mterry/webbrowser-app/switch-tab-keybinding

Revision history for this message
Olivier Tilloy (osomon) wrote :

LGTM, thanks for this useful contribution.

A couple of minor comments:

 - the call to focus recentView should probably be factored out to the implementation of internal.switchToTab()

 - can you update the autopilot tests in tests/autopilot/webbrowser_app/tests/test_keyboard.py to also test these new shortcuts (see test_switch_tabs)

« Back to merge proposal