Code review comment for lp:~mterry/update-notifier/pkexec

Revision history for this message
Colin Watson (cjwatson) wrote :

> -GKSU = ["/usr/bin/gksu"]
> -SYNPATIC_DESKTOP = ["--desktop",
> - "/usr/share/applications/synaptic.desktop",
> - "--"]
> +SUDO = ["/usr/bin/pkexec"]

If you're renaming the variable, call it PKEXEC, please, or at least
something that isn't the name of another tool. It's rather confusing
otherwise.

> === modified file 'data/cddistupgrader'
> --- data/cddistupgrader 2013-01-31 14:13:55 +0000
> +++ data/cddistupgrader 2013-01-31 23:13:25 +0000
> @@ -28,4 +28,4 @@
> done
>
> # run it
> -gksu -- "$TMPDIR"/"$CODENAME" --cdrom "$CDROM_MOUNT"
> +pkexec "$TMPDIR"/"$CODENAME" --cdrom "$CDROM_MOUNT"

I don't think this works for cddistupgrader, because the upgrader is
going to want to talk to the X server and pkexec doesn't allow that by
default.

I was considering shipping a polkit action file for cddistupgrader
itself and executing the whole lot under pkexec, which might be simpler
to arrange ...

« Back to merge proposal