Merge lp:~mterry/update-notifier/deprecations into lp:update-notifier/ubuntu

Proposed by Michael Terry
Status: Merged
Merged at revision: 596
Proposed branch: lp:~mterry/update-notifier/deprecations
Merge into: lp:update-notifier/ubuntu
Diff against target: 120 lines (+27/-10)
6 files modified
configure.in (+10/-1)
debian/changelog (+7/-1)
debian/control (+1/-1)
src/clipboard.c (+7/-5)
src/hooks.c (+1/-1)
src/update-notifier.c (+1/-1)
To merge this branch: bzr merge lp:~mterry/update-notifier/deprecations
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+37635@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.in'
2--- configure.in 2010-06-25 10:04:05 +0000
3+++ configure.in 2010-10-05 16:40:00 +0000
4@@ -12,7 +12,7 @@
5
6 GNOME_COMMON_INIT
7
8-pkg_modules="gtk+-2.0 gconf-2.0 dbus-glib-1 libnotify gio-2.0 x11"
9+pkg_modules="gtk+-2.0 >= 2.18.0 gconf-2.0 dbus-glib-1 libnotify gio-2.0 x11"
10
11 PKG_CHECK_EXISTS(gdu, [ HAVE_GDU=1 ])
12 if test "x$HAVE_GDU" != "x"; then
13@@ -65,6 +65,15 @@
14 AC_DEFINE(ENABLE_SCP, [1], [On-demand launching of system-config-printer.])
15 fi
16
17+AC_ARG_ENABLE([deprecations],
18+ [AS_HELP_STRING([--enable-deprecations],
19+ [allow deprecated API usage @<:@default=yes@:>@])],
20+ [],
21+ [enable_deprecations=yes])
22+AS_IF([test "x$enable_deprecations" = xno],
23+ [CFLAGS="-DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGSEAL_ENABLE"]
24+)
25+
26 AC_OUTPUT([
27 Makefile
28 src/Makefile
29
30=== modified file 'debian/changelog'
31--- debian/changelog 2010-09-09 12:13:12 +0000
32+++ debian/changelog 2010-10-05 16:40:00 +0000
33@@ -1,9 +1,15 @@
34 update-notifier (0.105ubuntu2) UNRELEASED; urgency=low
35
36+ [ Loïc Minier ]
37 * Update description to not mention adept/adept-notifier anymore, but "other
38 packages" and "server use cases" as adept doesn't exist anymore.
39
40- -- Loïc Minier <loic.minier@ubuntu.com> Thu, 09 Sep 2010 14:12:31 +0200
41+ [ Michael Terry ]
42+ * Add --disable-deprecations configure flag to test for deprecated API use
43+ * Don't use deprecated API, and update required version of GTK+ to match
44+ LP: #655231
45+
46+ -- Michael Terry <mterry@ubuntu.com> Tue, 05 Oct 2010 12:33:28 -0400
47
48 update-notifier (0.105ubuntu1) maverick; urgency=low
49
50
51=== modified file 'debian/control'
52--- debian/control 2010-09-09 12:13:12 +0000
53+++ debian/control 2010-10-05 16:40:00 +0000
54@@ -3,7 +3,7 @@
55 Priority: optional
56 Maintainer: Michael Vogt <michael.vogt@ubuntu.com>
57 Build-Depends: debhelper (>= 7.0.50~),
58- libgtk2.0-dev (>= 2.10.0),
59+ libgtk2.0-dev (>= 2.18.0),
60 libgconf2-dev,
61 libgdu-dev,
62 libdbus-glib-1-dev (>= 0.60),
63
64=== modified file 'src/clipboard.c'
65--- src/clipboard.c 2008-10-28 13:36:50 +0000
66+++ src/clipboard.c 2010-10-05 16:40:00 +0000
67@@ -47,12 +47,14 @@
68 gboolean retval = FALSE;
69 GtkClipboard *clipboard;
70 Atom atom;
71+ Display *display;
72
73 atom = gdk_x11_get_xatom_by_name (CLIPBOARD_NAME);
74-
75- XGrabServer (GDK_DISPLAY ());
76-
77- if (XGetSelectionOwner (GDK_DISPLAY (), atom) != None)
78+ display = gdk_x11_display_get_xdisplay (gdk_display_get_default ());
79+
80+ XGrabServer (display);
81+
82+ if (XGetSelectionOwner (display, atom) != None)
83 goto out;
84
85 clipboard = gtk_clipboard_get (gdk_atom_intern (CLIPBOARD_NAME, FALSE));
86@@ -64,7 +66,7 @@
87 retval = TRUE;
88
89 out:
90- XUngrabServer (GDK_DISPLAY ());
91+ XUngrabServer (display);
92 gdk_flush ();
93
94 return retval;
95
96=== modified file 'src/hooks.c'
97--- src/hooks.c 2010-08-23 08:58:54 +0000
98+++ src/hooks.c 2010-10-05 16:40:00 +0000
99@@ -547,7 +547,7 @@
100 return FALSE;
101
102 GtkWidget *d = GTK_WIDGET (gtk_builder_get_object(priv->gtk_builder,"dialog_hooks"));
103- if((d && GTK_WIDGET_VISIBLE(d)) || priv->active_notification != NULL)
104+ if((d && gtk_widget_get_visible(d)) || priv->active_notification != NULL)
105 return FALSE;
106
107 GdkRectangle area;
108
109=== modified file 'src/update-notifier.c'
110--- src/update-notifier.c 2010-08-23 08:58:54 +0000
111+++ src/update-notifier.c 2010-10-05 16:40:00 +0000
112@@ -157,7 +157,7 @@
113
114 // normal launch
115 context = gdk_app_launch_context_new ();
116- guint32 timestamp = gdk_x11_get_server_time (w->window);
117+ guint32 timestamp = gdk_x11_get_server_time (gtk_widget_get_window (w));
118 appinfo = g_app_info_create_from_commandline(cmd,
119 cmd,
120 G_APP_INFO_CREATE_NONE,

Subscribers

People subscribed via source and target branches

to all changes: