On Mon, Aug 20, 2012 at 02:45:38AM -0000, Michael Terry wrote: [..] > @@ -162,7 +163,7 @@ > > self._start_pane(UpdateProgress(self)) > > - def start_available(self): > + def start_available(self, cancelled_update = False): > self._look_busy() > self.refresh_cache() [..] > === modified file 'UpdateManager/UpdatesAvailable.py' > --- UpdateManager/UpdatesAvailable.py 2012-06-28 00:09:03 +0000 > +++ UpdateManager/UpdatesAvailable.py 2012-08-20 02:44:22 +0000 > @@ -81,7 +81,7 @@ > > class UpdatesAvailable(SimpleGtkbuilderApp): > > - def __init__(self, app): > + def __init__(self, app, header = None, desc = None): > self.window_main = app > self.datadir = app.datadir > self.options = app.options
pep8 suggests to use "cancelled_update=False" (no space around the "=").
Otherwise this looks good, would be nice to have a test, but to get it in before UIF I'm fine with merging it now.
Thanks, Michael
« Back to merge proposal
On Mon, Aug 20, 2012 at 02:45:38AM -0000, Michael Terry wrote: pane(UpdateProg ress(self) ) (self): (self, cancelled_update = False): cache() UpdatesAvailabl e.py' UpdatesAvailabl e.py 2012-06-28 00:09:03 +0000 UpdatesAvailabl e.py 2012-08-20 02:44:22 +0000 e(SimpleGtkbuil derApp) :
[..]
> @@ -162,7 +163,7 @@
>
> self._start_
>
> - def start_available
> + def start_available
> self._look_busy()
> self.refresh_
[..]
> === modified file 'UpdateManager/
> --- UpdateManager/
> +++ UpdateManager/
> @@ -81,7 +81,7 @@
>
> class UpdatesAvailabl
>
> - def __init__(self, app):
> + def __init__(self, app, header = None, desc = None):
> self.window_main = app
> self.datadir = app.datadir
> self.options = app.options
pep8 suggests to use "cancelled_ update= False" (no space around the
"=").
Otherwise this looks good, would be nice to have a test, but to get it
in before UIF I'm fine with merging it now.
Thanks,
Michael