Code review comment for lp:~mterry/update-manager/stop-update

Revision history for this message
Michael Vogt (mvo) wrote :

On Mon, Aug 20, 2012 at 02:45:38AM -0000, Michael Terry wrote:
[..]
> @@ -162,7 +163,7 @@
>
> self._start_pane(UpdateProgress(self))
>
> - def start_available(self):
> + def start_available(self, cancelled_update = False):
> self._look_busy()
> self.refresh_cache()
[..]
> === modified file 'UpdateManager/UpdatesAvailable.py'
> --- UpdateManager/UpdatesAvailable.py 2012-06-28 00:09:03 +0000
> +++ UpdateManager/UpdatesAvailable.py 2012-08-20 02:44:22 +0000
> @@ -81,7 +81,7 @@
>
> class UpdatesAvailable(SimpleGtkbuilderApp):
>
> - def __init__(self, app):
> + def __init__(self, app, header = None, desc = None):
> self.window_main = app
> self.datadir = app.datadir
> self.options = app.options

pep8 suggests to use "cancelled_update=False" (no space around the
"=").

Otherwise this looks good, would be nice to have a test, but to get it
in before UIF I'm fine with merging it now.

Thanks,
 Michael

« Back to merge proposal