Code review comment for lp:~mterry/unity8/unlock-script

Revision history for this message
Andy Doan (doanac) wrote :

> As for system-settle, why do your jenkins scripts need to run it before
> unlocking? I'm guessing you worry about the system being too loaded to unlock
> with autopilot? We have the sleep and retries for that, right? Could you
> just system-settle after unlocking instead of before?

My worry is that if system-settle takes too long, the screen will wind up being locked.

> I'm just leery of making this unlock script anything more than a black box.
> That said, it wouldn't kill me to add a "--settle=command" argument. With a
> default of "sleep 20" I guess... I'll work on that.

I understand. We've built up a set of requirements over time that are a bit awkward.

« Back to merge proposal