Code review comment for lp:~mterry/unity8/unlock-script
Revision history for this message
| Michael Terry (mterry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
As for system-settle, why do your jenkins scripts need to run it before unlocking? I'm guessing you worry about the system being too loaded to unlock with autopilot? We have the sleep and retries for that, right? Could you just system-settle after unlocking instead of before?
I'm just leery of making this unlock script anything more than a black box. That said, it wouldn't kill me to add a "--settle=command" argument. With a default of "sleep 20" I guess... I'll work on that.