Code review comment for lp:~mterry/unity8/test-early-disable

Revision history for this message
MichaƂ Sawicz (saviq) wrote :

This causes a test failure:

make testLightDMDBus

********* Start testing of GreeterDBusTest *********
Config: Using QtTest library 5.3.2, Qt 5.3.2
PASS : GreeterDBusTest::initTestCase()
PASS : GreeterDBusTest::testGetActiveEntry()
PASS : GreeterDBusTest::testSetActiveEntry()
PASS : GreeterDBusTest::testEntrySelectedSignal()
PASS : GreeterDBusTest::testActiveEntryGet()
PASS : GreeterDBusTest::testActiveEntrySet()
PASS : GreeterDBusTest::testActiveEntryChanged()
FAIL! : GreeterDBusTest::testEntryIsLockedGet() '!dbusList->property("EntryIsLocked").toBool()' returned FALSE. ()
   Loc: [../tests/plugins/LightDM/dbus.cpp(152)]
FAIL! : GreeterDBusTest::testEntryIsLockedChanged() 'arguments.at(1).toMap().contains("EntryIsLocked")' returned FALSE. ()
   Loc: [../tests/plugins/LightDM/dbus.cpp(167)]
PASS : GreeterDBusTest::testIsActive()
PASS : GreeterDBusTest::testShowGreeter()
PASS : GreeterDBusTest::cleanupTestCase()
Totals: 10 passed, 2 failed, 0 skipped
********* Finished testing of GreeterDBusTest *********

review: Needs Fixing

« Back to merge proposal