Code review comment for lp:~mterry/unity8/split

On 19.05.2014 16:04, Michael Terry wrote:
> * got an "incoming voice mail" item in the messaging indicator (not sure if related or where from...) - I sometimes get it in the session, sometimes in greeter, sometimes in both...
>
> Should be in both, and I've only ever happened to notice it in both. But I easily could have missed a time when it only showed in one because I never unlocked or whatever.
>
> I'm not exactly sure why telephony-service decides to show that when. But it gets the status from ofono, which is a system daemon. I would file this under "telephony/indicator bug" and don't personally think it's a blocker.

I just wonder where it's coming from in the first place - I don't have
it at all in current devel-proposed... And not really sure what to do
with it, no action available.

> * greeter indicators should fade-out on unlock
>
> Oh yeah? I thought the idea was to have it look like the indicator panel didn't change at all (as far as possible).

Yeah, in which case if they fade-out, you wouldn't see the change at all
anyway. I'm getting a rather jarring change (SEARCH appears, but that's
going away anyway, GSM icon appears, alarm icon appears, time format
changes...). In any case, it's a design question.

> * no GSM signal icon in greeter
>
> I get an icon. That is something I usually look for too, so I'm surprised to hear that. Is this an all-the-time problem?

Might be related to SIM unlocking.

> * at the end of unlock, session (?) launcher kicks in for a split second
>
> Not always. Only seems to if you are moving at a particular (relatively fast) speed. Right? That does seem odd. And it's the greeter launcher (you can tell if you have some running apps, they won't show up in greeter launcher). This is likely an issue in trunk, as I didn't change the teasing/swiping logic. But I'll have to confirm.

Confirmed in trunk.

> * brightness doesn't work on flo
>
> I don't have a flo. But what do you mean? Idle-dimming? But you say later that this is just a problem with flo at the moment.

Yeah, and I mean the brightness slider.

> * (related to previous comment) clearing voicemail doesn't clear in greeter (or the other way around)
>
> Known bug, we are going to live with that for now. Super annoying though, I agree. That problem exists for any incoming call or text message.

Ouch...

> * locale isn't communicated between session and greeter → time format changes between session and greeter
>
> Language should be communicated, right? Looks like I forgot about time.

Can't say that it is... I get everything in en.UTF-8 in greeter,
regardless of what I choose as the session language. Indicators will be
a problem here btw... Feels like we need to override their env language,
to be able to switch live as we switch users... Infographics should be
ok as they will now be static SVG files, they just need to be
regenerated on language change (inside the user's session).

> * can't unlock my SIM any more, the indicator shows full bars when I know the SIM is PIN-locked...
>
> I thought SIM unlocking was busted in trunk anyway? Ugh. I wasn't worrying about testing that, since I had heard it was busted. I don't have a locking SIM so I might need some help with that one.

Nope, it works fine. You need to press a button in the indicator to show
the PIN UI, but it works.