Code review comment for lp:~mterry/unity8/split

Revision history for this message
Michael Terry (mterry) wrote :

> Curious about the
> || true
> constructs in unity8-greeter-init.conf, can you explain what they are for?

Normally upstart jobs run with "set -e" so any failing line stops the job. And "initctl start" will fail if a job is already started or the job doesn't exist or some such. So we don't want to avoid running later jobs if earlier lines fail.

> modified file 'run_on_device.sh' (properties changed: +x to -x)

Crazy. I have no idea why I would have done that. Good catch.

> Do we really need this?
> view->resize(view->screen()->size());

Ah, that was for better desktop support (back in November!). We don't need it for Touch, and apparently desktop support is better for unity8 these days. So I'll drop after double-testing on Touch.

« Back to merge proposal