Code review comment for lp:~mterry/unity8/shutdown-dialog-on-resume

Revision history for this message
Albert Astals Cid (aacid) wrote :

property int powerKeyLongPressCount: 31 // about 2s
is something that depends on QStyleHints::keyboardAutoRepeatRate() and other things, those will probably won't change, but maybe we can add a test that actually checks that pressing and holidng the button triggers the dialog and takes between 1.5 and 2.5 seconds? just in case this varies wildly in the future with some update and we don't realize?

What do you think?

review: Needs Information

« Back to merge proposal