Code review comment for lp:~mterry/unity8/lockscreen-autopilot

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> > From what I understood from design, swiping the greeter should still be
> possible if it is not locked (i.e. for the guest user)
>
> I thought design's stance on the tablet mode is "whatever desktop does now".
> And the desktop greeter does not include swiping. I don't remember design
> specifically addressing swiping.
>
> > The linked bug is more about the lockscreens showing up in tablet mode even
> though the actual password entry is already handled on the greeter directly.
> So not really related to the swiping.
>
> The lockscreen showing up in tablet mode is fixed by the change in Shell.qml.
> The swiping is a bonus fix in Greeter.qml because it appeared to be making the
> same mistake Shell.qml did by treating 'locked' as a synonym for tablet mode
> (subject of course to whether swiping should be allowed in tablet mode or not,
> as per your first comment).

When I joined the unity team the Tablet greeter did only swipe and design had a hard time to accept that it cannot be swiped if a password on the Greeter is required. So I think they want it to swipe whenever possible unless they changed their mind like with the rotating list of users. We need to check back with them.

« Back to merge proposal