Merge lp:~mterry/unity8/greeter-hide-indicators into lp:unity8

Proposed by Michael Terry
Status: Merged
Approved by: Michael Terry
Approved revision: 2528
Merged at revision: 2539
Proposed branch: lp:~mterry/unity8/greeter-hide-indicators
Merge into: lp:unity8
Prerequisite: lp:~josharenson/unity8/sessions-model
Diff against target: 43 lines (+17/-3)
2 files modified
qml/Greeter/Greeter.qml (+6/-3)
tests/qmltests/tst_Shell.qml (+11/-0)
To merge this branch: bzr merge lp:~mterry/unity8/greeter-hide-indicators
Reviewer Review Type Date Requested Status
Michael Terry Approve
Unity8 CI Bot continuous-integration Pending
Lukáš Tinkl Pending
Review via email: mp+299344@code.launchpad.net

This proposal supersedes a proposal from 2016-06-30.

Commit message

Make sure indicators and launcher hide when power button is pressed on greeter.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
 No

 * Did you perform an exploratory manual test run of your code change and any related functionality?
 Yes

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
 NA

 * If you changed the UI, has there been a design review?
 NA

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2527
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1653/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/2193
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/2221
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/2127
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial+overlay/2127
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=yakkety/2127
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=yakkety/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=yakkety/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/2118/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2118
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=yakkety/2118/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/1653/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Lukáš Tinkl (lukas-kde) wrote : Posted in a previous version of this proposal

Better but not quite; you can still see the indicators "rolling up" when you wake the phone up. Previously you couldn't even see the animation, you were taken straight to the lockscreen.

review: Needs Information
Revision history for this message
Michael Terry (mterry) wrote : Posted in a previous version of this proposal

Are you sure that's a regression? I think it just depends on how long you wait until turning the screen back on.

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote : Posted in a previous version of this proposal

Ah :) I stand corrected, indeed if you wait a moment, it will hide completely.

* Did you perform an exploratory manual test run of the code change and any related functionality?

Yes

* Did CI run pass? If not, please explain why.

Not completely, passing locally

review: Approve
Revision history for this message
Michael Terry (mterry) wrote :

I've rebased on sessions-model, just to help keep the coming stack of greeter branches conflict free.

Re-approving from before.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'qml/Greeter/Greeter.qml'
--- qml/Greeter/Greeter.qml 2016-07-06 19:43:54 +0000
+++ qml/Greeter/Greeter.qml 2016-07-06 19:43:55 +0000
@@ -71,11 +71,14 @@
71 d.isLockscreen = true;71 d.isLockscreen = true;
72 }72 }
73 forcedUnlock = false;73 forcedUnlock = false;
74 if (!required) {74 if (required) {
75 showNow(); // loader.onLoaded will select a user75 // Normally loader.onLoaded will select a user, but if we're
76 } else {76 // already shown, do it manually.
77 d.selectUser(d.currentIndex, true);77 d.selectUser(d.currentIndex, true);
78 }78 }
79 // Even though we may already be shown, we want to call show() for its
80 // possible side effects, like hiding indicators and such.
81 showNow();
79 }82 }
8083
81 function notifyAppFocusRequested(appId) {84 function notifyAppFocusRequested(appId) {
8285
=== modified file 'tests/qmltests/tst_Shell.qml'
--- tests/qmltests/tst_Shell.qml 2016-07-06 19:43:54 +0000
+++ tests/qmltests/tst_Shell.qml 2016-07-06 19:43:55 +0000
@@ -1161,6 +1161,17 @@
1161 tryCompare(indicators, "fullyClosed", true);1161 tryCompare(indicators, "fullyClosed", true);
1162 }1162 }
11631163
1164 function test_greeterShownAgainHidesIndicators() {
1165 // Regression test for https://launchpad.net/bugs/1595569
1166
1167 loadShell("phone");
1168 showIndicators();
1169 showGreeter();
1170
1171 var indicators = findChild(shell, "indicators");
1172 tryCompare(indicators, "fullyClosed", true);
1173 }
1174
1164 function test_showAndHideGreeterDBusCalls() {1175 function test_showAndHideGreeterDBusCalls() {
1165 loadShell("phone");1176 loadShell("phone");
1166 swipeAwayGreeter();1177 swipeAwayGreeter();

Subscribers

People subscribed via source and target branches