Code review comment for lp:~mterry/unity8/dbus-race-fix

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> I've added a bit of logic to the existing Shell qmluitests to confirm that
> shell starts enabled and ends enabled. It's not 100% a great test since the
> mock PAM plugin we use returns instantly, so there's only a millisecond where
> the shell is disabled anyway. But can't hurt.
>
> What did you mean about checking shell.locked?

sorry. I meant shell.enabled.

Ok, thanks.

review: Approve

« Back to merge proposal