Code review comment for lp:~mterry/unity8/dbus-race-fix

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Ok. Code looks good. Tested it and it works. I think we should at least test the shell.enabled=true/false calls. Probably adding compare(shell.locked, true) at the beginning/end of existing tests would make sense to catch potential "lockup" bugs in future code modifications. What do you say?

review: Needs Information

« Back to merge proposal