Code review comment for lp:~mterry/unity8/cancel-pam-harder

Revision history for this message
Albert Astals Cid (aacid) wrote :

As far as i know, no, cancel won't terminate the thread, actually i think would not cancel authenticateWithPam in the middle of an execution, it's just that the future has not started executing and is cancelled before doing so.

As discussed on irc, please "add code to verify that all respond() have been properly dispatched"

review: Needs Fixing

« Back to merge proposal