Unity 8

Code review comment for lp:~mterry/unity8/cancel-pam-harder

  1. cancel-pam-harder
  2. Merge into trunk
Revision history for this message
Albert Astals Cid (aacid) wrote :

Small fix:
 * You can change the two futureWatcher.future().something() to futureWatcher.something()

About QCoreApplication::processEvents it's a bit on the nasty side, is it possible to put the code in a slot attached to the futurewatcher finished signal?

Also does respond(QString()) need to happen repeteadly inside the loop or just once?

review: Needs Information

« Back to merge proposal