Code review comment for lp:~mterry/unity-system-compositor/inactivity-zero-fix

Revision history for this message
Alexandros Frantzis (afrantzis) wrote :

> Hrm... There might also be a bug in MirScreen around a notification happening
> while the screen is on. This would set a timeout of, say, 15s. And if the
> user didn't cause any activity in those 15s, the screen would turn off, which
> isn't correct...
>
> This needs a quick additional think.

I have proposed an alternative branch (which incorporates the change proposed in this branch), plus behavioral improvements for the scenario you describe, plus tests:

https://code.launchpad.net/~afrantzis/unity-system-compositor/fix-1485737-notification-with-inactivity-zero

Let me know how it works for you.

« Back to merge proposal