Merge lp:~mterry/unity-lens-applications/modern-build into lp:unity-lens-applications

Proposed by Michael Terry
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 318
Merged at revision: 318
Proposed branch: lp:~mterry/unity-lens-applications/modern-build
Merge into: lp:unity-lens-applications
Prerequisite: lp:~mterry/unity-lens-applications/sync-packaging
Diff against target: 104 lines (+19/-17)
8 files modified
data/Makefile.am (+1/-1)
data/unity-lens-applications.service.in (+1/-1)
debian/changelog (+4/-0)
debian/compat (+1/-1)
debian/control (+1/-2)
debian/rules (+10/-9)
debian/unity-lens-applications.install (+0/-2)
src/Makefile.am (+1/-1)
To merge this branch: bzr merge lp:~mterry/unity-lens-applications/modern-build
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Approve
PS Jenkins bot continuous-integration Pending
Review via email: mp+133402@code.launchpad.net

Commit message

Switch from cdbs to dh9 and run tests

Description of the change

Use a more modern build system for debian/:
 * Switch from cdbs to dh9
 * Use --fail-missing (not strictly needed, since we only have one binary package, but helps for future-proofing)
 * Automatically run tests due to dh9
 * Change from libexecdir to pkglibexecdir, now that dh9 fixes the long standing bug that set the wrong libexecdir

Note that debian/unity-lens-applications.install is dropped because dh9 automatically installs everything that the upstream build system does for you, as long as there is only one binary package. So the .install file is superfluous (and actually harmful as it causes a build problem).

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Works completely fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'data/Makefile.am'
--- data/Makefile.am 2011-11-15 12:31:25 +0000
+++ data/Makefile.am 2012-11-08 04:51:21 +0000
@@ -6,7 +6,7 @@
6dbus_services_DATA = $(service_in_files:.service.in=.service)6dbus_services_DATA = $(service_in_files:.service.in=.service)
77
8%.service: %.service.in8%.service: %.service.in
9 sed -e "s|\@libexecdir\@|$(libexecdir)|" $< > $@9 sed -e "s|\@pkglibexecdir\@|$(pkglibexecdir)|" $< > $@
1010
11#############################################################11#############################################################
12# XDG Menu files12# XDG Menu files
1313
=== modified file 'data/unity-lens-applications.service.in'
--- data/unity-lens-applications.service.in 2011-08-04 07:04:35 +0000
+++ data/unity-lens-applications.service.in 2012-11-08 04:51:21 +0000
@@ -1,3 +1,3 @@
1[D-BUS Service]1[D-BUS Service]
2Name=com.canonical.Unity.Lens.Applications2Name=com.canonical.Unity.Lens.Applications
3Exec=@libexecdir@/unity-applications-daemon3Exec=@pkglibexecdir@/unity-applications-daemon
44
=== modified file 'debian/changelog'
--- debian/changelog 2012-11-08 04:51:21 +0000
+++ debian/changelog 2012-11-08 04:51:21 +0000
@@ -3,7 +3,11 @@
3 * debian/control:3 * debian/control:
4 - Update Vcs-Bzr4 - Update Vcs-Bzr
5 - Bump required valac to 0.185 - Bump required valac to 0.18
6 - Bump required debhelper to 9 and drop cdbs
6 - Fix libgnome-menu-dev Build-Dep to be libgnome-menu-3-dev7 - Fix libgnome-menu-dev Build-Dep to be libgnome-menu-3-dev
8 * debian/rules:
9 - Use dh9 instead of cdbs
10 - Use --fail-missing
711
8 -- Michael Terry <mterry@ubuntu.com> Wed, 07 Nov 2012 23:10:52 -050012 -- Michael Terry <mterry@ubuntu.com> Wed, 07 Nov 2012 23:10:52 -0500
913
1014
=== modified file 'debian/compat'
--- debian/compat 2010-06-23 09:51:59 +0000
+++ debian/compat 2012-11-08 04:51:21 +0000
@@ -1,1 +1,1 @@
1719
22
=== modified file 'debian/control'
--- debian/control 2012-11-08 04:51:21 +0000
+++ debian/control 2012-11-08 04:51:21 +0000
@@ -2,8 +2,7 @@
2Section: gnome2Section: gnome
3Priority: optional3Priority: optional
4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5Build-Depends: cdbs,5Build-Depends: debhelper (>= 9),
6 debhelper (>= 7),
7 gnome-common,6 gnome-common,
8 pkg-config,7 pkg-config,
9 valac-0.18 (>= 0.18.0),8 valac-0.18 (>= 0.18.0),
109
=== modified file 'debian/rules'
--- debian/rules 2012-11-05 19:18:41 +0000
+++ debian/rules 2012-11-08 04:51:21 +0000
@@ -1,11 +1,12 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
22
3include /usr/share/cdbs/1/class/gnome.mk3export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs -Wl,--as-needed
4include /usr/share/cdbs/1/rules/debhelper.mk4
5include /usr/share/cdbs/1/rules/utils.mk5%:
6include /usr/share/cdbs/1/rules/autoreconf.mk6 dh $@ --with autoreconf
77
8LDFLAGS += -Wl,-z,defs -Wl,--as-needed8override_dh_autoreconf:
9DEB_DH_AUTORECONF_ARGS = env -- NOCONFIGURE=1 ./autogen.sh9 NOCONFIGURE=1 dh_autoreconf ./autogen.sh
10DEB_CONFIGURE_EXTRA_FLAGS += --sysconfdir=/etc10
1111override_dh_install:
12 dh_install --fail-missing
1213
=== removed file 'debian/unity-lens-applications.install'
--- debian/unity-lens-applications.install 2011-08-04 08:30:33 +0000
+++ debian/unity-lens-applications.install 1970-01-01 00:00:00 +0000
@@ -1,2 +0,0 @@
1etc/
2usr/
30
=== modified file 'src/Makefile.am'
--- src/Makefile.am 2012-11-05 19:18:41 +0000
+++ src/Makefile.am 2012-11-08 04:51:21 +0000
@@ -5,7 +5,7 @@
55
6DATADIR = $(datadir)6DATADIR = $(datadir)
77
8libexec_PROGRAMS = \8pkglibexec_PROGRAMS = \
9 unity-applications-daemon9 unity-applications-daemon
1010
11unity_applications_daemon_CPPFLAGS = \11unity_applications_daemon_CPPFLAGS = \

Subscribers

People subscribed via source and target branches