Code review comment for lp:~mterry/unity-greeter/animation-fixes

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Looks good to me and with the minimal testing I did, it functions well.

My only comment is the old code that was removed included some really great comments describing how the animations are calculated. It would be nice to have similar comments describing the current calculations. Certainly not a blocker, but the previous code comments seemed like excellent documentation of the logic used.

review: Approve

« Back to merge proposal