Merge lp:~mterry/ubuntu/maverick/apturl/gtkbuilder into lp:apturl

Proposed by Michael Terry
Status: Merged
Merged at revision: 100
Proposed branch: lp:~mterry/ubuntu/maverick/apturl/gtkbuilder
Merge into: lp:apturl
Diff against target: 377 lines (+67/-65)
9 files modified
AptUrl/gtk/GtkUI.py (+9/-10)
AptUrl/kde/KdeUI.py (+1/-1)
data/apturl-gtk.ui (+46/-48)
debian/apturl-kde.install (+1/-1)
debian/apturl.install (+1/-1)
debian/changelog (+6/-0)
debian/control (+1/-2)
po/POTFILES.in (+1/-1)
setup.py (+1/-1)
To merge this branch: bzr merge lp:~mterry/ubuntu/maverick/apturl/gtkbuilder
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+37619@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'AptUrl/gtk/GtkUI.py'
--- AptUrl/gtk/GtkUI.py 2010-03-08 16:17:34 +0000
+++ AptUrl/gtk/GtkUI.py 2010-10-05 15:16:15 +0000
@@ -2,7 +2,6 @@
2import pygtk2import pygtk
3pygtk.require("2.0")3pygtk.require("2.0")
4import gtk4import gtk
5import gtk.glade
6import gobject5import gobject
7gobject.threads_init()6gobject.threads_init()
8import subprocess7import subprocess
@@ -24,10 +23,10 @@
24 def __init__(self):23 def __init__(self):
25 gtk.init_check()24 gtk.init_check()
26 # create empty dialog25 # create empty dialog
27 self.dia_xml = gtk.glade.XML('/usr/share/apturl/apturl.glade', 26 self.dia_xml = gtk.Builder()
28 'confirmation_dialog', 27 self.dia_xml.set_translation_domain("apturl")
29 "apturl")28 self.dia_xml.add_from_file('/usr/share/apturl/apturl-gtk.ui')
30 self.dia = self.dia_xml.get_widget('confirmation_dialog')29 self.dia = self.dia_xml.get_object('confirmation_dialog')
31 self.dia.realize()30 self.dia.realize()
3231
33 # generic dialogs32 # generic dialogs
@@ -139,11 +138,11 @@
139 body = _("Do you want to install package '%s'?") % package138 body = _("Do you want to install package '%s'?") % package
140 dia.set_keep_above(True)139 dia.set_keep_above(True)
141 dia.set_title('')140 dia.set_title('')
142 header_label = dia_xml.get_widget('header_label')141 header_label = dia_xml.get_object('header_label')
143 header_label.set_markup("<b><big>%s</big></b>" % header)142 header_label.set_markup("<b><big>%s</big></b>" % header)
144 body_label = dia_xml.get_widget('body_label')143 body_label = dia_xml.get_object('body_label')
145 body_label.set_label(body)144 body_label.set_label(body)
146 description_text_view = dia_xml.get_widget('description_text_view')145 description_text_view = dia_xml.get_object('description_text_view')
147 tbuf = gtk.TextBuffer()146 tbuf = gtk.TextBuffer()
148 desc = "%s\n\n%s" % (summary, Helpers.format_description(description))147 desc = "%s\n\n%s" % (summary, Helpers.format_description(description))
149 tbuf.set_text(desc)148 tbuf.set_text(desc)
@@ -156,8 +155,8 @@
156 # be locked via apt_pkg.GetLock() 155 # be locked via apt_pkg.GetLock()
157 # - but that needs to run as root 156 # - but that needs to run as root
158 # - a dbus helper might be the best answer here157 # - a dbus helper might be the best answer here
159 #args = (update_button_status, dia_xml.get_widget("yes_button"),158 #args = (update_button_status, dia_xml.get_object("yes_button"),
160 # dia_xml.get_widget("infolabel"))159 # dia_xml.get_object("infolabel"))
161 #args[0](*args[1:])160 #args[0](*args[1:])
162 #timer_id = gobject.timeout_add(750, *args )161 #timer_id = gobject.timeout_add(750, *args )
163 162
164163
=== modified file 'AptUrl/kde/KdeUI.py'
--- AptUrl/kde/KdeUI.py 2010-08-07 03:11:07 +0000
+++ AptUrl/kde/KdeUI.py 2010-10-05 15:16:15 +0000
@@ -39,7 +39,7 @@
39 self.d = QWidget(self.dialog)39 self.d = QWidget(self.dialog)
40 self.dialog.setMainWidget(self.d)40 self.dialog.setMainWidget(self.d)
4141
42 uic.loadUi('/usr/share/apturl/apturl.ui', self.d)42 uic.loadUi('/usr/share/apturl/apturl-qt.ui', self.d)
43 self.d.image_label.setPixmap(KIcon("application-x-deb").pixmap(64,64))43 self.d.image_label.setPixmap(KIcon("application-x-deb").pixmap(64,64))
4444
45 # generic dialogs45 # generic dialogs
4646
=== renamed file 'data/apturl.glade' => 'data/apturl-gtk.ui'
--- data/apturl.glade 2009-01-08 19:46:00 +0000
+++ data/apturl-gtk.ui 2010-10-05 15:16:15 +0000
@@ -1,8 +1,7 @@
1<?xml version="1.0" encoding="UTF-8" standalone="no"?>1<?xml version="1.0"?>
2<!DOCTYPE glade-interface SYSTEM "glade-2.0.dtd">
3<!--*- mode: xml -*-->2<!--*- mode: xml -*-->
4<glade-interface>3<interface>
5 <widget class="GtkDialog" id="confirmation_dialog">4 <object class="GtkDialog" id="confirmation_dialog">
6 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>5 <property name="events">GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK</property>
7 <property name="border_width">5</property>6 <property name="border_width">5</property>
8 <property name="window_position">GTK_WIN_POS_CENTER_ON_PARENT</property>7 <property name="window_position">GTK_WIN_POS_CENTER_ON_PARENT</property>
@@ -10,61 +9,61 @@
10 <property name="skip_taskbar_hint">True</property>9 <property name="skip_taskbar_hint">True</property>
11 <property name="has_separator">False</property>10 <property name="has_separator">False</property>
12 <child internal-child="vbox">11 <child internal-child="vbox">
13 <widget class="GtkVBox" id="dialog-vbox1">12 <object class="GtkVBox" id="dialog-vbox1">
14 <property name="visible">True</property>13 <property name="visible">True</property>
15 <property name="spacing">2</property>14 <property name="spacing">2</property>
16 <child>15 <child>
17 <widget class="GtkHBox" id="hbox1">16 <object class="GtkHBox" id="hbox1">
18 <property name="visible">True</property>17 <property name="visible">True</property>
19 <property name="spacing">10</property>18 <property name="spacing">10</property>
20 <child>19 <child>
21 <widget class="GtkImage" id="dialog_image">20 <object class="GtkImage" id="dialog_image">
22 <property name="visible">True</property>21 <property name="visible">True</property>
23 <property name="yalign">0</property>22 <property name="yalign">0</property>
24 <property name="stock">gtk-dialog-question</property>23 <property name="stock">gtk-dialog-question</property>
25 <property name="icon_size">6</property>24 <property name="icon_size">6</property>
26 </widget>25 </object>
27 <packing>26 <packing>
28 <property name="expand">False</property>27 <property name="expand">False</property>
29 </packing>28 </packing>
30 </child>29 </child>
31 <child>30 <child>
32 <widget class="GtkVBox" id="vbox1">31 <object class="GtkVBox" id="vbox1">
33 <property name="visible">True</property>32 <property name="visible">True</property>
34 <property name="spacing">12</property>33 <property name="spacing">12</property>
35 <child>34 <child>
36 <widget class="GtkLabel" id="header_label">35 <object class="GtkLabel" id="header_label">
37 <property name="visible">True</property>36 <property name="visible">True</property>
38 <property name="xalign">0</property>37 <property name="xalign">0</property>
39 <property name="use_markup">True</property>38 <property name="use_markup">True</property>
40 </widget>39 </object>
41 <packing>40 <packing>
42 <property name="expand">False</property>41 <property name="expand">False</property>
43 </packing>42 </packing>
44 </child>43 </child>
45 <child>44 <child>
46 <widget class="GtkLabel" id="body_label">45 <object class="GtkLabel" id="body_label">
47 <property name="visible">True</property>46 <property name="visible">True</property>
48 <property name="xalign">0</property>47 <property name="xalign">0</property>
49 </widget>48 </object>
50 <packing>49 <packing>
51 <property name="expand">False</property>50 <property name="expand">False</property>
52 <property name="position">1</property>51 <property name="position">1</property>
53 </packing>52 </packing>
54 </child>53 </child>
55 <child>54 <child>
56 <widget class="GtkExpander" id="description_expander">55 <object class="GtkExpander" id="description_expander">
57 <property name="visible">True</property>56 <property name="visible">True</property>
58 <property name="can_focus">True</property>57 <property name="can_focus">True</property>
59 <child>58 <child>
60 <widget class="GtkScrolledWindow" id="scrolledwindow1">59 <object class="GtkScrolledWindow" id="scrolledwindow1">
61 <property name="visible">True</property>60 <property name="visible">True</property>
62 <property name="can_focus">True</property>61 <property name="can_focus">True</property>
63 <property name="hscrollbar_policy">GTK_POLICY_NEVER</property>62 <property name="hscrollbar_policy">GTK_POLICY_NEVER</property>
64 <property name="vscrollbar_policy">GTK_POLICY_AUTOMATIC</property>63 <property name="vscrollbar_policy">GTK_POLICY_AUTOMATIC</property>
65 <property name="shadow_type">GTK_SHADOW_OUT</property>64 <property name="shadow_type">GTK_SHADOW_OUT</property>
66 <child>65 <child>
67 <widget class="GtkTextView" id="description_text_view">66 <object class="GtkTextView" id="description_text_view">
68 <property name="width_request">400</property>67 <property name="width_request">400</property>
69 <property name="height_request">200</property>68 <property name="height_request">200</property>
70 <property name="visible">True</property>69 <property name="visible">True</property>
@@ -74,42 +73,39 @@
74 <property name="wrap_mode">GTK_WRAP_WORD</property>73 <property name="wrap_mode">GTK_WRAP_WORD</property>
75 <property name="left_margin">5</property>74 <property name="left_margin">5</property>
76 <property name="right_margin">5</property>75 <property name="right_margin">5</property>
77 </widget>76 </object>
78 </child>77 </child>
79 </widget>78 </object>
80 </child>79 </child>
81 <child>80 <child type="label">
82 <widget class="GtkLabel" id="description_label">81 <object class="GtkLabel" id="description_label">
83 <property name="visible">True</property>82 <property name="visible">True</property>
84 <property name="label" translatable="yes">Description</property>83 <property name="label" translatable="yes">Description</property>
85 </widget>84 </object>
86 <packing>
87 <property name="type">label_item</property>
88 </packing>
89 </child>85 </child>
90 </widget>86 </object>
91 <packing>87 <packing>
92 <property name="position">2</property>88 <property name="position">2</property>
93 </packing>89 </packing>
94 </child>90 </child>
95 </widget>91 </object>
96 <packing>92 <packing>
97 <property name="position">1</property>93 <property name="position">1</property>
98 </packing>94 </packing>
99 </child>95 </child>
100 </widget>96 </object>
101 <packing>97 <packing>
102 <property name="padding">5</property>98 <property name="padding">5</property>
103 <property name="position">1</property>99 <property name="position">1</property>
104 </packing>100 </packing>
105 </child>101 </child>
106 <child>102 <child>
107 <widget class="GtkLabel" id="infolabel">103 <object class="GtkLabel" id="infolabel">
108 <property name="visible">True</property>104 <property name="visible">True</property>
109 <property name="xalign">1</property>105 <property name="xalign">1</property>
110 <property name="use_markup">True</property>106 <property name="use_markup">True</property>
111 <property name="justify">GTK_JUSTIFY_RIGHT</property>107 <property name="justify">GTK_JUSTIFY_RIGHT</property>
112 </widget>108 </object>
113 <packing>109 <packing>
114 <property name="expand">False</property>110 <property name="expand">False</property>
115 <property name="fill">False</property>111 <property name="fill">False</property>
@@ -117,11 +113,11 @@
117 </packing>113 </packing>
118 </child>114 </child>
119 <child internal-child="action_area">115 <child internal-child="action_area">
120 <widget class="GtkHButtonBox" id="dialog-action_area1">116 <object class="GtkHButtonBox" id="dialog-action_area1">
121 <property name="visible">True</property>117 <property name="visible">True</property>
122 <property name="layout_style">GTK_BUTTONBOX_END</property>118 <property name="layout_style">GTK_BUTTONBOX_END</property>
123 <child>119 <child>
124 <widget class="GtkButton" id="no_button">120 <object class="GtkButton" id="no_button">
125 <property name="visible">True</property>121 <property name="visible">True</property>
126 <property name="can_focus">True</property>122 <property name="can_focus">True</property>
127 <property name="has_focus">True</property>123 <property name="has_focus">True</property>
@@ -129,61 +125,63 @@
129 <property name="has_default">True</property>125 <property name="has_default">True</property>
130 <property name="label">gtk-cancel</property>126 <property name="label">gtk-cancel</property>
131 <property name="use_stock">True</property>127 <property name="use_stock">True</property>
132 <property name="response_id">0</property>128 </object>
133 </widget>
134 </child>129 </child>
135 <child>130 <child>
136 <widget class="GtkButton" id="yes_button">131 <object class="GtkButton" id="yes_button">
137 <property name="visible">True</property>132 <property name="visible">True</property>
138 <property name="can_focus">True</property>133 <property name="can_focus">True</property>
139 <property name="response_id">-8</property>
140 <child>134 <child>
141 <widget class="GtkAlignment" id="alignment1">135 <object class="GtkAlignment" id="alignment1">
142 <property name="visible">True</property>136 <property name="visible">True</property>
143 <property name="xscale">0</property>137 <property name="xscale">0</property>
144 <property name="yscale">0</property>138 <property name="yscale">0</property>
145 <child>139 <child>
146 <widget class="GtkHBox" id="hbox2">140 <object class="GtkHBox" id="hbox2">
147 <property name="visible">True</property>141 <property name="visible">True</property>
148 <property name="spacing">2</property>142 <property name="spacing">2</property>
149 <child>143 <child>
150 <widget class="GtkImage" id="image1">144 <object class="GtkImage" id="image1">
151 <property name="visible">True</property>145 <property name="visible">True</property>
152 <property name="stock">gtk-save</property>146 <property name="stock">gtk-save</property>
153 </widget>147 </object>
154 <packing>148 <packing>
155 <property name="expand">False</property>149 <property name="expand">False</property>
156 <property name="fill">False</property>150 <property name="fill">False</property>
157 </packing>151 </packing>
158 </child>152 </child>
159 <child>153 <child>
160 <widget class="GtkLabel" id="label1">154 <object class="GtkLabel" id="label1">
161 <property name="visible">True</property>155 <property name="visible">True</property>
162 <property name="label" translatable="yes">_Install</property>156 <property name="label" translatable="yes">_Install</property>
163 <property name="use_underline">True</property>157 <property name="use_underline">True</property>
164 </widget>158 </object>
165 <packing>159 <packing>
166 <property name="expand">False</property>160 <property name="expand">False</property>
167 <property name="fill">False</property>161 <property name="fill">False</property>
168 <property name="position">1</property>162 <property name="position">1</property>
169 </packing>163 </packing>
170 </child>164 </child>
171 </widget>165 </object>
172 </child>166 </child>
173 </widget>167 </object>
174 </child>168 </child>
175 </widget>169 </object>
176 <packing>170 <packing>
177 <property name="position">1</property>171 <property name="position">1</property>
178 </packing>172 </packing>
179 </child>173 </child>
180 </widget>174 </object>
181 <packing>175 <packing>
182 <property name="expand">False</property>176 <property name="expand">False</property>
183 <property name="pack_type">GTK_PACK_END</property>177 <property name="pack_type">GTK_PACK_END</property>
184 </packing>178 </packing>
185 </child>179 </child>
186 </widget>180 </object>
187 </child>181 </child>
188 </widget>182 <action-widgets>
189</glade-interface>183 <action-widget response="0">no_button</action-widget>
184 <action-widget response="-8">yes_button</action-widget>
185 </action-widgets>
186 </object>
187</interface>
190188
=== renamed file 'data/apturl.ui' => 'data/apturl-qt.ui'
=== modified file 'debian/apturl-kde.install'
--- debian/apturl-kde.install 2009-09-01 19:09:49 +0000
+++ debian/apturl-kde.install 2010-10-05 15:16:15 +0000
@@ -1,3 +1,3 @@
1usr/bin/apturl-kde1usr/bin/apturl-kde
2usr/lib/python2.6/site-packages/AptUrl/kde/*py*2usr/lib/python2.6/site-packages/AptUrl/kde/*py*
3usr/share/apturl/*ui3usr/share/apturl/*-qt.ui
44
=== modified file 'debian/apturl.install'
--- debian/apturl.install 2009-09-01 19:09:49 +0000
+++ debian/apturl.install 2010-10-05 15:16:15 +0000
@@ -1,4 +1,4 @@
1usr/bin/apturl-gtk1usr/bin/apturl-gtk
2usr/lib/python2.6/site-packages/AptUrl/gtk/*py*2usr/lib/python2.6/site-packages/AptUrl/gtk/*py*
3usr/share/apturl/*glade3usr/share/apturl/*-gtk.ui
4usr/share/gconf4usr/share/gconf
55
=== modified file 'debian/changelog'
--- debian/changelog 2010-09-07 15:40:47 +0000
+++ debian/changelog 2010-10-05 15:16:15 +0000
@@ -1,3 +1,9 @@
1apturl (0.4.1ubuntu8) UNRELEASED; urgency=low
2
3 * Switch from glade to GtkBuilder (LP: #403533)
4
5 -- Michael Terry <mterry@ubuntu.com> Tue, 05 Oct 2010 11:06:24 -0400
6
1apturl (0.4.1ubuntu7) maverick; urgency=low7apturl (0.4.1ubuntu7) maverick; urgency=low
28
3 * Fix KDE protocol files to enlist in the local protocol class9 * Fix KDE protocol files to enlist in the local protocol class
410
=== modified file 'debian/control'
--- debian/control 2010-09-07 15:40:47 +0000
+++ debian/control 2010-10-05 15:16:15 +0000
@@ -38,9 +38,8 @@
38 gconf2,38 gconf2,
39 gksu (>= 2.0.0-1ubuntu3),39 gksu (>= 2.0.0-1ubuntu3),
40 gnome-icon-theme (>= 2.14.0-1),40 gnome-icon-theme (>= 2.14.0-1),
41 python-glade2 (>= 2.6.3-2),
42 python-gobject,41 python-gobject,
43 python-gtk2 (>= 2.6.3-2),42 python-gtk2 (>= 2.12),
44 python-webkit,43 python-webkit,
45 python-vte (>= 1:0.11.15-4),44 python-vte (>= 1:0.11.15-4),
46 software-properties-gtk,45 software-properties-gtk,
4746
=== modified file 'po/POTFILES.in'
--- po/POTFILES.in 2009-08-26 14:09:53 +0000
+++ po/POTFILES.in 2010-10-05 15:16:15 +0000
@@ -6,6 +6,6 @@
6AptUrl/UI.py6AptUrl/UI.py
7AptUrl/gtk/GtkUI.py7AptUrl/gtk/GtkUI.py
8AptUrl/kde/KdeUI.py8AptUrl/kde/KdeUI.py
9data/apturl.glade9[type: gettext/glade] data/apturl-gtk.ui
10data/apturl.schemas.in10data/apturl.schemas.in
1111
1212
=== modified file 'setup.py'
--- setup.py 2010-07-27 12:43:56 +0000
+++ setup.py 2010-10-05 15:16:15 +0000
@@ -29,7 +29,7 @@
29 packages=['AptUrl','AptUrl.gtk','AptUrl.kde'],29 packages=['AptUrl','AptUrl.gtk','AptUrl.kde'],
30 scripts=['apturl','apturl-gtk','apturl-kde'],30 scripts=['apturl','apturl-gtk','apturl-kde'],
31 data_files=[('share/apturl/',31 data_files=[('share/apturl/',
32 ["data/apturl.glade","data/apturl.ui"]),32 ["data/apturl-gtk.ui","data/apturl-qt.ui"]),
33 ('../etc/firefox/pref/',33 ('../etc/firefox/pref/',
34 ["data/apturl.js"]),34 ["data/apturl.js"]),
35 ('share/kde4/services/',35 ('share/kde4/services/',

Subscribers

People subscribed via source and target branches