Code review comment for lp:~mterry/ubuntu-system-settings/kill-maliit
Revision history for this message
| Michael Terry (mterry) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> Out of interest, why can't this be done in maliit's job?
> Just from looking, it feels as if adding 'or starting'
> and 'or stopping' cases for the wizard would work to
> start and stop maliit when you want to.
There's a technical reason -- some things we want to do before unity8 starts to avoid race condition. But the wizard starts on "starting unity8" so as soon as the wizard's *target* is set to "stopped," upstart will continue with unity8. So the only way to guarantee we get to do something before unity8 starts is to do it in the cleanup job, before our target is set to "stopped."
But also, I figured that the wizard was a special case situation, not part of the "normal operation." So I didn't want to clutter up maliit's job and preferred that the wizard be self-contained.