Code review comment for lp:~mterry/qtmir/ms-compressed-timestamps

Revision history for this message
Gerry Boland (gerboland) wrote :

+ std::chrono::nanoseconds result = (timestamp - startTime) / 1000000;
shouldn't the result be in std::chrono::milliseconds? chrono does implicit conversion between nano & milliseconds, should be able to use that instead of the explicit division.

Your editor does something odd to the file line endings, can you undo that?

I'll let Daniel or Nick review the principle

« Back to merge proposal