On 03/12/2015 18:22, Michael Terry wrote:
>> In Application::setInternalState(Application::InternalState state):
>> [snip]
> True. That whole switch statement could use a lot of cleanup as there are several duplicate entries. But it looks like an intentional choice on Gerry's part, and this change in this branch is really just a revert to bring this code back to what it looked like.
>
I wrote that code, not Gerry.
What I do want to keep is the order in which the enum items appear in
the switch: They should be the same as in the enum declaration.
And there's already a precedent for that: the Starting case and the
SuspendingWait* ones.
On 03/12/2015 18:22, Michael Terry wrote: :setInternalSta te(Application: :InternalState state):
>> In Application:
>> [snip]
> True. That whole switch statement could use a lot of cleanup as there are several duplicate entries. But it looks like an intentional choice on Gerry's part, and this change in this branch is really just a revert to bring this code back to what it looked like.
>
I wrote that code, not Gerry.
What I do want to keep is the order in which the enum items appear in
the switch: They should be the same as in the enum declaration.
And there's already a precedent for that: the Starting case and the
SuspendingWait* ones.