Code review comment for lp:~mterry/phablet-tools/welcome-wizard-disable

Revision history for this message
Francis Ginther (fginther) wrote :

I discussed this with the CI team and we don't have any comments on the actual code changes, just some questions on some possible implications:

1) Is this a no-op if ubuntu-system-settings-wizard is not available? I'm just making sure this change doesn't need to be in lock-step with some other change.

2) Are there cases when we don't want to disable this wizard? I can see that for all of our current testing this is needed. Do we have a testing gap for this wizard that we eventually need to cover?

3) Just to make a note, it would be helpful to have a single option which disabled both the intro and the welcome-wizard and could be used as an umbrella option for any other tweak that needs to be done before automated tests can run. But I can see this being outside the scope of this MP and don't want to bog this one down.

review: Needs Information

« Back to merge proposal