Code review comment for lp:~mterry/oxide/mirserver

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

> + } else if (platform.startsWith("ubuntu") || platform ==
> QLatinString("mirserver")) {
> void* handle = pni->nativeResourceForContext("eglcontext", context);
>
> Note, the mirserver QPA does not have this "eglcontext" native resource
> exported. That may cause issues

In that case, it would be worth just dropping the change in qt/core/gpu/oxide_qt_gl_context_dependent.cc, as it won't work anyway. This is only used to determine the application provided share group (if there is one), and Oxide trunk no longer needs a share group if the platform is EGL and supports EGL_KHR_gl_texture_2D_image. In the worst case, it should fall back gracefully to software compositing mode anyway.

« Back to merge proposal