Code review comment for lp:~mterry/indicator-appmenu/emit-show-now-changed

Revision history for this message
Ted Gould (ted) wrote :

On Tue, 2011-03-08 at 17:16 +0000, Michael Terry wrote:
> + /* Set up initial state for new entries if needed */
> + if (window_menus_get_status (iapp->default_app) != DBUSMENU_STATUS_NORMAL) {
> + window_status_changed (iapp->default_app,
> + window_menus_get_status (iapp->default_app),
> + iapp);
> + }

I think that we need to ensure that the one we're switching from wasn't
setting the status to alert as well. I think that the best way to do
this to track the state and see if it changes as we change menus.

  review needsfixing

review: Needs Fixing

« Back to merge proposal