Merge lp:~mterry/indicator-application/dont-wildly-free-apps into lp:indicator-application/0.4

[Michael Terry]

In debugging bug 743564, which I'm not sure is 100% this same bug, I had a hard time seeing how it could happen unless an Application object weren't properly freed. I got a crash doing similar things with a wildly different stack but the same conclusion.

So I started looking at how we freed Applications. And lo and behold, at one point we just g_free it, instead of application_free! I don't know how likely this code branch is, but it is 100% a crash bug if we do hit it.

I further guarded the free with !app->validated because similar code a few lines up does if the callback had an error.

[Ted Gould (ted)]

review: Approve

=== modified file 'src/application-service-appstore.c'
--- src/application-service-appstore.c	2011-04-07 14:10:11 +0000
+++ src/application-service-appstore.c	2011-04-08 20:38:28 +0000
@@ -498,7 +498,8 @@
 	if (menu == NULL || id == NULL || category == NULL || status == NULL ||
 	    icon_name == NULL) {
 		g_warning("Notification Item on object %s of %s doesn't have enough properties.", app->dbus_object, app->dbus_name);
-		g_free(app); // Need to do more than this, but it gives the idea of the flow we're going for.
+		if (!app->validated)
+			application_free(app);
 	}
 	else {
 		app->validated = TRUE;