Merge lp:~mterry/indicator-application/dont-wildly-free-apps into lp:indicator-application/0.4
Proposed by
Michael Terry
Status: | Merged |
---|---|
Approved by: | Ted Gould |
Approved revision: | 196 |
Merged at revision: | 196 |
Proposed branch: | lp:~mterry/indicator-application/dont-wildly-free-apps |
Merge into: | lp:indicator-application/0.4 |
Diff against target: |
13 lines (+2/-1) 1 file modified
src/application-service-appstore.c (+2/-1) |
To merge this branch: | bzr merge lp:~mterry/indicator-application/dont-wildly-free-apps |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+57012@code.launchpad.net |
Description of the change
In debugging bug 743564, which I'm not sure is 100% this same bug, I had a hard time seeing how it could happen unless an Application object weren't properly freed. I got a crash doing similar things with a wildly different stack but the same conclusion.
So I started looking at how we freed Applications. And lo and behold, at one point we just g_free it, instead of application_free! I don't know how likely this code branch is, but it is 100% a crash bug if we do hit it.
I further guarded the free with !app->validated because similar code a few lines up does if the callback had an error.
To post a comment you must log in.