Code review comment for lp:~mterry/cupstream2distro-config/move-camera

Revision history for this message
Francis Ginther (fginther) wrote :

This looks really good. My only comment is that qtubuntu-camera can be reduced to the following:

    qtubuntu-camera:
      hooks: D08add_ppa-qt5-proper D09add_ppa-phablet-team-ppa A10checklicenseheaders
      configurations:
        quantal-i386: False
        raring-i386: False
        raring-amd64: False

Note: if a 'configurations' stanza is define outside of the 'ci' and 'autolanding' stanzas, then it will apply to both.

review: Needs Fixing

« Back to merge proposal