Code review comment for lp:~mterry/aptdaemon/progress-tweaks

In the long term, I think Update Manager should use its own progress UI rather than Aptdaemon's progress window. In <https://wiki.ubuntu.com/SoftwareUpdates#Installing> I show the initial prompt morphing into the progress window, when later morphs into the report of success or failure; that's probably difficult as long as they're separate executables. More importantly, Aptdaemon's progress window probably should be modal to its parent window, so that -- for example -- a media player isn't confused by you doing something else in its window while it is blocked waiting for a codec to install. The Software Updater progress window, meanwhile, shouldn't be modal to anything.

If that's true, then this --

- functions = Gdk.WMFunction.MOVE|Gdk.WMFunction.RESIZE
+ functions = Gdk.WMFunction.MOVE|Gdk.WMFunction.RESIZE|Gdk.WMFunction.MINIMIZE

-- is not a good idea. You shouldn't be able to minimize a dialog independently of its parent window.

+ # Setup the label, progressbar, and cancel button

Grammar nit: "Setup" is a noun. The verb is "Set up". (I mention this because it's a common UI mistake too.)

+ self.label_role.set_markup("<big><b>%s</b></big>" % self.custom_label)

+ self.label_role.set_markup("<big><b>%s</b></big>" % role)

This is a progress window, not an alert, so the text shouldn't be any larger or bolder than normal.

Thanks!