Merge lp:~mterry/appmenu-gtk/fix-sensitive-actions into lp:appmenu-gtk/0.4

Proposed by Michael Terry
Status: Merged
Merged at revision: 107
Proposed branch: lp:~mterry/appmenu-gtk/fix-sensitive-actions
Merge into: lp:appmenu-gtk/0.4
Diff against target: 16 lines (+6/-0)
1 file modified
src/bridge.c (+6/-0)
To merge this branch: bzr merge lp:~mterry/appmenu-gtk/fix-sensitive-actions
Reviewer Review Type Date Requested Status
Cody Russell (community) Approve
Review via email: mp+47056@code.launchpad.net

Description of the change

The GtkAction "notify" handler was looking up the visible status when notified about "sensitive" changes. This is a patch to change that as well as add a stanza for watching when the action's "visible" state changes.

The sensitive/visible mixup MAY be responsible for the bug I've seen where every once in a blue moon, gedit's menu will be insensitive. I've not been able to reproduce it, but I'm not the only one that's seen it.

To post a comment you must log in.
Revision history for this message
Cody Russell (bratsche) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/bridge.c'
--- src/bridge.c 2011-01-14 17:25:07 +0000
+++ src/bridge.c 2011-01-21 16:41:22 +0000
@@ -682,6 +682,12 @@
682 {682 {
683 dbusmenu_menuitem_property_set_bool (mi,683 dbusmenu_menuitem_property_set_bool (mi,
684 DBUSMENU_MENUITEM_PROP_ENABLED,684 DBUSMENU_MENUITEM_PROP_ENABLED,
685 gtk_action_is_sensitive (action));
686 }
687 else if (pspec->name == g_intern_static_string ("visible"))
688 {
689 dbusmenu_menuitem_property_set_bool (mi,
690 DBUSMENU_MENUITEM_PROP_VISIBLE,
685 gtk_action_is_visible (action));691 gtk_action_is_visible (action));
686 }692 }
687 else if (pspec->name == g_intern_static_string ("active"))693 else if (pspec->name == g_intern_static_string ("active"))

Subscribers

People subscribed via source and target branches