Code review comment for lp:~mterry/appmenu-gtk/fix-alt-shortcuts

Revision history for this message
Ted Gould (ted) wrote :

On Wed, 2011-03-09 at 20:12 +0000, Michael Terry wrote:
> To fix this, I used the sorta-secret gobject data "dbusmenu-gtk-parser-cached-item" saved on GtkMenuItems by the parser to map to Dbusmenuitems. This may be considered bad?
>
> If it is considered bad to use that string directly, we should either expose the string in a header or introduce a convenience function to dbusmenu to grab the data.

I think it's better to expose via API. What do you think about:

  lp:~ted/dbusmenu/get-cached-menuitem

I think that works and is API we could support for a while.

« Back to merge proposal