Merge lp:~mterry/address-book-service/snap-root into lp:address-book-service

Proposed by Michael Terry
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 227
Merged at revision: 226
Proposed branch: lp:~mterry/address-book-service/snap-root
Merge into: lp:address-book-service
Diff against target: 49 lines (+6/-6)
4 files modified
updater/ab-update-buteo-import.cpp (+1/-1)
updater/ab-update.cpp (+3/-3)
upstart/address-book-service.conf.in (+1/-1)
upstart/address-book-updater.conf.in (+1/-1)
To merge this branch: bzr merge lp:~mterry/address-book-service/snap-root
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Review via email: mp+310599@code.launchpad.net

Commit message

Handle running inside of a snap by respecting the $SNAP variable and not using hard coded paths.

Description of the change

Handle running inside of a snap.

To post a comment you must log in.
227. By Michael Terry

Fix whitespace typo

Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'updater/ab-update-buteo-import.cpp'
--- updater/ab-update-buteo-import.cpp 2015-10-20 23:22:29 +0000
+++ updater/ab-update-buteo-import.cpp 2016-11-11 00:22:48 +0000
@@ -59,7 +59,7 @@
59#define SYNCMONITOR_DBUS_OBJECT_PATH "/com/canonical/SyncMonitor"59#define SYNCMONITOR_DBUS_OBJECT_PATH "/com/canonical/SyncMonitor"
60#define SYNCMONITOR_DBUS_INTERFACE "com.canonical.SyncMonitor"60#define SYNCMONITOR_DBUS_INTERFACE "com.canonical.SyncMonitor"
6161
62#define TRANSFER_ICON "/usr/share/icons/suru/status/scalable/transfer-progress.svg"62#define TRANSFER_ICON "transfer-progress"
6363
64using namespace QtContacts;64using namespace QtContacts;
6565
6666
=== modified file 'updater/ab-update.cpp'
--- updater/ab-update.cpp 2015-10-20 20:38:19 +0000
+++ updater/ab-update.cpp 2016-11-11 00:22:48 +0000
@@ -28,9 +28,9 @@
28#include <QtCore/QDir>28#include <QtCore/QDir>
29#include <QtNetwork/QNetworkConfiguration>29#include <QtNetwork/QNetworkConfiguration>
3030
31#define TRANSFER_ICON "/usr/share/icons/suru/status/scalable/transfer-progress.svg"31#define TRANSFER_ICON "transfer-progress"
32#define TRANSFER_ICON_PAUSED "/usr/share/icons/suru/status/scalable/transfer-paused.svg"32#define TRANSFER_ICON_PAUSED "transfer-paused"
33#define TRANSFER_ICON_ERROR "/usr/share/icons/suru/status/scalable/transfer-error.svg"33#define TRANSFER_ICON_ERROR "transfer-error"
3434
3535
36ABUpdate::ABUpdate(QObject *parent)36ABUpdate::ABUpdate(QObject *parent)
3737
=== modified file 'upstart/address-book-service.conf.in'
--- upstart/address-book-service.conf.in 2015-09-09 19:07:42 +0000
+++ upstart/address-book-service.conf.in 2016-11-11 00:22:48 +0000
@@ -14,4 +14,4 @@
14 echo "STOP `date`"14 echo "STOP `date`"
15end script15end script
1616
17exec @CMAKE_INSTALL_FULL_LIBEXECDIR@/address-book-service17exec $SNAP@CMAKE_INSTALL_FULL_LIBEXECDIR@/address-book-service
1818
=== modified file 'upstart/address-book-updater.conf.in'
--- upstart/address-book-updater.conf.in 2015-10-09 13:57:11 +0000
+++ upstart/address-book-updater.conf.in 2016-11-11 00:22:48 +0000
@@ -4,4 +4,4 @@
4start on started address-book-service and started msyncd and started sync-monitor4start on started address-book-service and started msyncd and started sync-monitor
5stop on runlevel [06]5stop on runlevel [06]
66
7exec @CMAKE_INSTALL_FULL_LIBEXECDIR@/address-book-updater --sync7exec $SNAP@CMAKE_INSTALL_FULL_LIBEXECDIR@/address-book-updater --sync

Subscribers

People subscribed via source and target branches