Code review comment for lp:~mspacek/qpdfview/cachezoom

Revision history for this message
Adam Reichold (adamreichold) wrote :

Hello again,

Am 23.06.2014 15:44, schrieb Martin Spacek:
> For the current revision of this branch, I'm noticing cache
> collisions on page refresh. Do I maybe need to do something in the
> PageItem destructor?
>

yes, within the PageItem destructor, you need to find all entries
which belong to this page and remove them so they can't be reused.
This also implies that the PageItem pointer needs to be recoverable
from the cache key. (And as said earlier, you will need to do the same
thing whenever annotations or form fields change.)

Best regards, Adam.

« Back to merge proposal