Code review comment for lp:~mskalka/juju-ci-tools/remove-constraints-from-bootstrap

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is fine to merge, but you must also be prepare to revert. While mem=2G is being ignored by Juju 2 because it does not satisfy juju controller minimums, the value is still used in models. We may find some tests fail in some substrates because our tests do not set a minimum requirement.

If add_basic_testing_arguments() provided --constraints, could tune tests for substrates. This will be a requirement if you need to revert.

review: Approve (code)

« Back to merge proposal