Code review comment for lp:~mskalka/juju-ci-tools/assess-destroy-model

Revision history for this message
Aaron Bentley (abentley) wrote :

--format json or --format yaml is an option with basically every query command (show-x, list-x). I prefer json because the parser is much faster (which can affect unit test speed), you don't need to tell it to be safe, and it's part of the standard library. Unfortunately, juju's json output is not human-readable. (You can pretty-print it by piping it to jq, though.)

I still recommend explaining the difference between get_current_model, get_current_controller, and Juju2Backend.get_active_model in the docstring. Otherwise, someone will "helpfully" remove the code duplication sooner or later.

However, this looks like a response to bug #1505504. Cheryl adjusted the scope of bug #1582021 to be just the timing hole: https://bugs.launchpad.net/juju-ci-tools/+bug/1582021/comments/1

« Back to merge proposal