Code review comment for lp:~mskalka/juju-ci-tools/assess-destroy-model

Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you Michael. This test needs another round of changes. In general never use "assert" and always raise JujuAssertionError when juju fails. Juju errors are being logged as info, but the test will still pass. You might want to consider using
    with logged_exception(logging):
to log exceptions without needing to write log.error.

review: Needs Fixing (code)

« Back to merge proposal