Code review comment for ~msaikia/cloud-init:topic-msaikia-vmware-custom-script

Revision history for this message
Maitreyee Saikia (msaikia) wrote :

Thanks Chad,
I have addressed your comments.
Please take a look at the review request.
Regards,

> Maitreyee, I believe that is exactly the behavior we want to be common across
> all of cloud-init. Right now, if /var/lib/cloud is cleaned up and the machine
> is rebooted, we expect cloud-init to re-perform all configuration steps as if
> it is run on against clean system. In fact we are adding a cloud-init clean
> commandline function to do just that:
>
> https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-
> init/+merge/333513
>
> Also, per filesystem heirarchy standard, we also shouldn't be leaking files to
> other directories beyond what the cloud-init package 'owns'. It's okay if we
> haven't yet sorted the details of leaving around vmware marker files (or
> cleaning up former config changes due to those customizations. This lack of
> 'cleanup' handling is something that cloud-init will have to tackle for ssh
> keys or users created which may have been left on the system by the first
> cloud-init run, and may need removing before reboot.

« Back to merge proposal