Code review comment for ~msaikia/cloud-init:topic-msaikia-vmware-custom-script

Revision history for this message
Maitreyee Saikia (msaikia) wrote :

> Maitreyee, one last pass on this from me. Could you please add a couple unit
> tests which exercise the OVF get_data execution path with customizationscript
> present (and erroring) to ensure that behavior is properly handled. (probably
> looking for tests in tests/unittests/test_datasource/test_ovf.py

Hi Chad,
We have some tests in tests/unittests/test_vmware/test_custom_script.py, where we are testing for cases when customscript is not present.
Do you want me to test the calling function? The calling function does not error out if the variable "customscript" is not set. The if condition here is only to determine whether to go to that workflow or not? If not, we just move to the next configuration. All the error conditions are tested in the actual function, as to whether the correct error is raised or not.
Do you still want me to add tests on the calling function?

« Back to merge proposal