Code review comment for lp:~msabramo/capturemock/tests

Understandable that you want to use TextTest.

Take a look at
https://code.launchpad.net/~msabramo/capturemock/tests_add_misc_tests/+merge/197564when
you get a chance. I tried to convert some of my py.test tests into
equivalent TextTest tests.

I'm not sure how to do the test that exercises recording while using the
requests module -- that adds a dependency on having the requests module
installed and you may not want to require that (or maybe you do, I don't
know). I could vendor "requests" into the CaptureMock tests but then that
would make the tests repo bigger, so you might not want that. Let me know
if you have a preferred approach for dealing with testing things that
require external modules...

Marc

On Mon, Dec 2, 2013 at 12:48 PM, Geoff Bache <email address hidden> wrote:

> Hi Marc,
>
> Thanks for all this, I'll try and review it in more detail later this week.
> Seems like you might have found a couple of bugs here as well, which is
> very useful!
>
> Fundamentally, there are already 138 fairly comprehensive acceptance tests
> for CaptureMock using TextTest (around 97% coverage), so simply adding some
> new ones that run via nose or py.test won't really help us very much. To
> actually be useful, we would need to translate the entire test suite
> really, which is probably only worth the effort if you (or some other
> non-TextTest user) are planning to do serious development and has
> insurmountable problems installing TextTest. In addition, CaptureMock is
> not just Python interception, it's also command-line and network traffic
> interception, and these parts particularly seem to fit very naturally to
> TextTest's model of running external processes and comparing files
> produced, and less so to nose and py.test which are more designed for
> arranging and asserting within a Python process.
>
> I'd be happy to help troubleshoot why you couldn't install TextTest if
> you'd like, or take these tests and convert them to TextTest myself. If you
> have a Mac, the TextTest GUI is likely to be problematic as GTK isn't
> maintained there. But you can still run TextTest tests via the console
> interface, without needing GTK. On Linux or Windows the GUI should be no
> problem. On a Mac you can always create a Linux VM and run the GUI there.
>
> Regards,
> Geoff Bache
> --
> https://code.launchpad.net/~msabramo/capturemock/tests/+merge/197297
> You are the owner of lp:~msabramo/capturemock/tests.
>