PBXT

Merge lp:~ms-fk/pbxt/trunk into lp:pbxt

  1. trunk
  2. Merge into trunk
Proposed by Martin Scholl
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ms-fk/pbxt/trunk
Merge into: lp:pbxt
Diff against target: 11 lines (+1/-0)
1 file modified
src/myxt_xt.cc (+1/-0)
To merge this branch: bzr merge lp:~ms-fk/pbxt/trunk
Reviewer Review Type Date Requested Status
PBXT Core Pending
Review via email: mp+19196@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Scholl (ms-fk) wrote :

Hi all,

please verify this is actually needed; having read the surrounding code, it seems so.

HiH,
Martin

Revision history for this message
Paul McCullagh (paul-mccullagh) wrote :

Hi Martin,

Indeed, the init() call is missing.

I'm impressed! :)

On Feb 12, 2010, at 8:37 PM, Martin Scholl wrote:

> Martin Scholl has proposed merging lp:~ms-fk/pbxt/trunk into lp:pbxt.
>
> Requested reviews:
> PBXT Core (pbxt-core)
>
>
> Hi all,
>
>
> please verify this is actually needed; having read the surrounding
> code, it seems so.
>
>
> HiH,
> Martin
> --
> https://code.launchpad.net/~ms-fk/pbxt/trunk/+merge/19196
> Your team PBXT Core is subscribed to branch lp:pbxt.
> === modified file 'src/myxt_xt.cc'
> --- src/myxt_xt.cc 2010-01-22 13:24:35 +0000
> +++ src/myxt_xt.cc 2010-02-12 19:37:18 +0000
> @@ -2859,6 +2859,7 @@
> for (key_part = key->key_part; key_part != key_part_end; key_part+
> +) {
> if (!(cref = new XTDDColumnRef()))
> xt_throw_errno(XT_CONTEXT, XT_ENOMEM);
> + cref->init(self);
> ind->co_cols.append(self, cref);
> cref->cr_col_name = xt_dup_string(self, (char *) key_part->field-
> >field_name);
> }
>

--
Paul McCullagh
PrimeBase Technologies
www.primebase.org
www.blobstreaming.org
pbxt.blogspot.com

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/myxt_xt.cc'
2--- src/myxt_xt.cc 2010-01-22 13:24:35 +0000
3+++ src/myxt_xt.cc 2010-02-12 19:37:18 +0000
4@@ -2859,6 +2859,7 @@
5 for (key_part = key->key_part; key_part != key_part_end; key_part++) {
6 if (!(cref = new XTDDColumnRef()))
7 xt_throw_errno(XT_CONTEXT, XT_ENOMEM);
8+ cref->init(self);
9 ind->co_cols.append(self, cref);
10 cref->cr_col_name = xt_dup_string(self, (char *) key_part->field->field_name);
11 }

Subscribers

People subscribed via source and target branches