Code review comment for lp:~mrooney/ecryptfs/pythonapi

Revision history for this message
Michael Rooney (mrooney) wrote :

Dustin, this is the API branch and is ready to go. I created a new python/ directory in src/ which the UI utilities assume is shipped as a dist/site package of python named "ecryptfs" (for example as /usr/lib/python2.6/dist-packages/ecryptfs/)

The two things to resolve before packaging are:
 - should it be somewhere different in the ecryptfs source?
 - I'm expecting an 'ecryptfs' module to be added to dist-packages but 'ecryptfs-utils' already exists for the swig wrappers. They should perhaps be unified, and you can't import something with a dash in the name in python anyway so the existing module is suboptimal. If it isn't too invasive we might want to move the three methods (ecryptfs_passphrase_blob, ecryptfs_passphrase_sig_from_blob, ecryptfs_add_blob_to_keyring) to ecryptapi.py and adjust any references.

« Back to merge proposal