Code review comment for lp:~mrazik/jenkins-launchpad-plugin/stale-locks-take2

Revision history for this message
Francis Ginther (fginther) wrote :

I still need to review the tests, but I have the following comments (as discussed in our 1 on 1):

In trigger_ci_build() and trigger_al_build(), the
    if launchpadutils.testing_in_progress(mp, jenkins_job):
        continue

check should be the last check before proceeding to the trigger as it is likely the most time and resource intensive check.

review: Needs Fixing

« Back to merge proposal