> The changes look good, the template changes adequately replace the old dput-
> mbs-pt jobs. There are some pep8 errors so marking as needs-fixing:
> $ pep8 .
> ./tests/test_cu2dUpdateCi.py:82:63: E231 missing whitespace after ','
> ./tests/test_cu2dUpdateCi.py:92:63: E231 missing whitespace after ','
> ./tests/test_cu2dUpdateCi.py:104:63: E231 missing whitespace after ','
> ./tests/test_cu2dUpdateCi.py:119:63: E231 missing whitespace after ','
> ./tests/test_cu2dUpdateCi.py:148:63: E231 missing whitespace after ','
Oops. Fixed.
> This replaces the bulk of the mbs jenkins jobs. The missing piece is the
> automatic rebuild of downstream dependencies. For example, if a new compiz is
> built, the old mbs jobs will rebuild unity with the unity-build-mbs-pt job.
Is this a regression in the context of lp:cupstream2distro-config? I was actually wondering about this earlier today and had an impression the current oif deployment suffers from the same problem?
> There is also the *-check-mbs-pt jobs which are used to defer a rebuild if
> another upstream MP is pending, but these should be removed anyway. If we care
> about unintended API breakages, we still have some work to do (open a bug for
> this?).
> The changes look good, the template changes adequately replace the old dput- test_cu2dUpdate Ci.py:82: 63: E231 missing whitespace after ',' test_cu2dUpdate Ci.py:92: 63: E231 missing whitespace after ',' test_cu2dUpdate Ci.py:104: 63: E231 missing whitespace after ',' test_cu2dUpdate Ci.py:119: 63: E231 missing whitespace after ',' test_cu2dUpdate Ci.py:148: 63: E231 missing whitespace after ','
> mbs-pt jobs. There are some pep8 errors so marking as needs-fixing:
> $ pep8 .
> ./tests/
> ./tests/
> ./tests/
> ./tests/
> ./tests/
Oops. Fixed.
> This replaces the bulk of the mbs jenkins jobs. The missing piece is the
> automatic rebuild of downstream dependencies. For example, if a new compiz is
> built, the old mbs jobs will rebuild unity with the unity-build-mbs-pt job.
Is this a regression in the context of lp:cupstream2distro-config? I was actually wondering about this earlier today and had an impression the current oif deployment suffers from the same problem?
> There is also the *-check-mbs-pt jobs which are used to defer a rebuild if
> another upstream MP is pending, but these should be removed anyway. If we care
> about unintended API breakages, we still have some work to do (open a bug for
> this?).
If its not a regression (in lp:cupstream2distro-config) then yes, we should open a bug.